2011/12/23 Rafael Aquini <aquini@xxxxxxxxxx>: > While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern: > <tracepoint-name>_begin > <tarcepoint-name>_end > > However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency. > > Signed-off-by: Rafael Aquini <aquini@xxxxxxxxxx> I don't think it's big issue. but seems no harm change. Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > --- > include/trace/events/vmscan.h | 2 +- > mm/vmscan.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > index edc4b3d..615bd6d 100644 > --- a/include/trace/events/vmscan.h > +++ b/include/trace/events/vmscan.h > @@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_re > TP_ARGS(nr_reclaimed) > ); > > -TRACE_EVENT(mm_shrink_slab_start, > +TRACE_EVENT(mm_shrink_slab_begin, > TP_PROTO(struct shrinker *shr, struct shrink_control *sc, > long nr_objects_to_shrink, unsigned long pgs_scanned, > unsigned long lru_pgs, unsigned long cache_items, > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f54a05b..b24a593 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -301,7 +301,7 @@ unsigned long shrink_slab(struct shrink_control *shrink, > if (total_scan > max_pass * 2) > total_scan = max_pass * 2; > > - trace_mm_shrink_slab_start(shrinker, shrink, nr, > + trace_mm_shrink_slab_begin(shrinker, shrink, nr, > nr_pages_scanned, lru_pages, > max_pass, delta, total_scan); > > -- > 1.7.7.4 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxx. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href