On 12/29/21 12:22, Hyeonggon Yoo wrote: > On Wed, Dec 22, 2021 at 05:56:50PM +0100, Vlastimil Babka wrote: >> On 12/14/21 13:57, Vlastimil Babka wrote: >> > On 12/1/21 19:14, Vlastimil Babka wrote: >> >> Folks from non-slab subsystems are Cc'd only to patches affecting them, and >> >> this cover letter. >> >> >> >> Series also available in git, based on 5.16-rc3: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slab-struct_slab-v2r2 >> > >> > Pushed a new branch slab-struct-slab-v3r3 with accumulated fixes and small tweaks >> > and a new patch from Hyeonggon Yoo on top. To avoid too much spam, here's a range diff: >> >> Hi, I've pushed another update branch slab-struct_slab-v4r1, and also to >> -next. I've shortened git commit log lines to make checkpatch happier, >> so no range-diff as it would be too long. I believe it would be useless >> spam to post the whole series now, shortly before xmas, so I will do it >> at rc8 time, to hopefully collect remaining reviews. But if anyone wants >> a mailed version, I can do that. >> > > Hello Matthew and Vlastimil. > it's part 3 of review. > > # mm: Convert struct page to struct slab in functions used by other subsystems > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> > > > # mm/slub: Convert most struct page to struct slab by spatch > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> > Tested-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> > with a question below. > > -static int check_slab(struct kmem_cache *s, struct page *page) > +static int check_slab(struct kmem_cache *s, struct slab *slab) > { > int maxobj; > > - if (!PageSlab(page)) { > - slab_err(s, page, "Not a valid slab page"); > + if (!folio_test_slab(slab_folio(slab))) { > + slab_err(s, slab, "Not a valid slab page"); > return 0; > } > > Can't we guarantee that struct slab * always points to a slab? Normally, yes. > for struct page * it can be !PageSlab(page) because struct page * > can be other than slab. but struct slab * can only be slab > unlike struct page. code will be simpler if we guarantee that > struct slab * always points to a slab (or NULL). That's what the code does indeed. But check_slab() is called as part of various consistency checks, so there we on purpose question all assumptions in order to find a bug (e.g. memory corruption) - such as a page that's still on the list of slabs while it was already freed and reused and thus e.g. lacks the slab page flag. But it's nice how using struct slab makes such a check immediately stand out as suspicious, right? > # mm/slub: Convert pfmemalloc_match() to take a struct slab > It's confusing to me because the original pfmemalloc_match() is removed > and pfmemalloc_match_unsafe() was renamed to pfmemalloc_match() and > converted to use slab_test_pfmemalloc() helper. > > But I agree with the resulting code. so: > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> > > > # mm/slub: Convert alloc_slab_page() to return a struct slab > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> > Tested-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> > > > # mm/slub: Convert print_page_info() to print_slab_info() > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> > > I hope to review rest of patches in a week. Thanks for your reviews/tests!
