On Thu, Dec 23, 2021 at 06:34:22PM +0000, Sean Christopherson wrote: > On Thu, Dec 23, 2021, Chao Peng wrote: > > > > -kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o $(KVM)/memfd.o > > This should be > > kvm-$(CONFIG_MEMFD_OPS) += $(KVM)/memfd.o > > with stubs provided in a header file as needed. I also really dislike naming KVM's > file memfd.c, though I don't have a good alternative off the top of my head. Is memory-backend.c better? if we end up introducing the callback definition in KVM we can call it CONFIG_KVM_MEMORY_BACKEDN_OPS. Chao