Re: [PATCH v2] memcg: add per-memcg vmalloc stat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 21, 2021 at 9:50 PM Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:
>
> On Wed, Dec 22, 2021 at 1:25 PM Shakeel Butt <shakeelb@xxxxxxxxxx> wrote:
> >
> [...]
> > @@ -2626,6 +2627,9 @@ static void __vunmap(const void *addr, int deallocate_pages)
> >                 unsigned int page_order = vm_area_page_order(area);
> >                 int i;
> >
> > +               mod_memcg_page_state(area->pages[0], MEMCG_VMALLOC,
> > +                                    -(int)area->nr_pages);
>
> The cast can go away since the type of 3rd parameter of
> mod_memcg_page_state() is int but not long. I suggest
> to remove it. Anyway

Andrew, please remove this cast of the third param when you add this
patch in the mm tree.

>
> Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

Thanks.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux