Re: [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021-12-16 08:02, Christoph Hellwig wrote:
@@ -147,7 +142,7 @@ struct iova *reserve_iova(struct iova_domain *iovad, unsigned long pfn_lo,
  	unsigned long pfn_hi);
  void init_iova_domain(struct iova_domain *iovad, unsigned long granule,
  	unsigned long start_pfn);
-int init_iova_flush_queue(struct iova_domain *iovad, iova_flush_cb flush_cb);
+int init_iova_flush_queue(struct iova_domain *iovad, struct iommu_domain *fq_domain);

Overly long line here.

Fear not, it disappears again in the final patch. In cases like this I much prefer to minimise the amount of churn within the series, to keep the patches focused on the meaningful changes.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks for the reviews!

Robin.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux