On 2021-12-14 17:18, John Garry via iommu wrote:
On 10/12/2021 17:54, Robin Murphy wrote:
+ iovad->fq_domain = fq_domain;
+ iovad->fq = queue;
+
+ timer_setup(&iovad->fq_timer, fq_flush_timeout, 0);
+ atomic_set(&iovad->fq_timer_on, 0);
+
+ return 0;
+}
+
+
nit: a single blank line is standard, I think
Hmm, you're right - I've grown fond of leaving an extra little bit of
breathing space between logically-independent sections of code, and for
some reason I thought this file was already in that style, but indeed it
isn't.
Joerg - let me know if you feel strongly enough that you'd like me to
change that. I'm going to have one last go at fixing tegra-drm, so I'm
happy to send a v3 of the whole series later this week if there are any
other minor tweaks too.
Thanks for all the reviews!
Robin.
Cheers
static inline size_t cookie_msi_granule(struct iommu_dma_cookie
*cookie)
{
_______________________________________________
iommu mailing list
iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/iommu