On 12/14/21 15:20, Johannes Weiner wrote: > On Wed, Dec 01, 2021 at 07:14:38PM +0100, Vlastimil Babka wrote: >> These two wrappers around their respective struct page variants will be useful >> in the following patches. >> >> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx> > > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> Thanks! > Slight reviewer preference: introduce helpers when they're first used, > as it's a little easier to understand the application without having > to chase new folio_address() -> new slab_address() -> first user of > slab_address() through the patchset. Yeah would normally do that but with the current folio work going on there was a chance the helpers would be useful to somebody else too and cherry-picking a patch that adds them without user is simpler. And indeed Matthew just asked about virt_to_folio() few days ago :)
