Re: [PATCH v4 10/23] nvme-pci: check DMA ops when indicating support for PCI P2PDMA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Logan Gunthorpe <logang@xxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v4 10/23] nvme-pci: check DMA ops when indicating support for PCI P2PDMA
From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
Date: Mon, 13 Dec 2021 22:10:51 +0000
Accept-language: en-US
Cc: Stephen Bates <sbates@xxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Christian König <christian.koenig@xxxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, Don Dutile <ddutile@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Daniel Vetter <daniel.vetter@xxxxxxxx>, Jakowski Andrzej <andrzej.jakowski@xxxxxxxxx>, Minturn Dave B <dave.b.minturn@xxxxxxxxx>, Jason Ekstrand <jason@xxxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Xiong Jianxin <jianxin.xiong@xxxxxxxxx>, Bjorn Helgaas <helgaas@xxxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Martin Oliveira <martin.oliveira@xxxxxxxxxxxxx>, Chaitanya Kulkarni <ckulkarnilinux@xxxxxxxxx>
In-reply-to: <20211117215410.3695-11-logang@deltatee.com>
References: <20211117215410.3695-1-logang@deltatee.com> <20211117215410.3695-11-logang@deltatee.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 11/17/21 1:53 PM, Logan Gunthorpe wrote:
> Introduce a supports_pci_p2pdma() operation in nvme_ctrl_ops to
> replace the fixed NVME_F_PCI_P2PDMA flag such that the dma_map_ops
> flags can be checked for PCI P2PDMA support.
> 
> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

References:
- [PATCH v4 00/23] Userspace P2PDMA with O_DIRECT NVMe devices
  - From: Logan Gunthorpe
- [PATCH v4 10/23] nvme-pci: check DMA ops when indicating support for PCI P2PDMA
  - From: Logan Gunthorpe

Prev by Date: Re: [PATCH v4 04/23] PCI/P2PDMA: Expose pci_p2pdma_map_type()
Next by Date: Re: [PATCH v4 11/23] nvme-pci: convert to using dma_map_sgtable()
Previous by thread: [PATCH v4 10/23] nvme-pci: check DMA ops when indicating support for PCI P2PDMA
Next by thread: [PATCH v4 03/23] PCI/P2PDMA: Attempt to set map_type if it has not been set
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]