Re: [PATCH] mm:remove unneeded variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> return value form directly instead of
> taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: chiminghao <chi.minghao@xxxxxxxxxx>
> ---
>  mm/truncate.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/mm/truncate.c b/mm/truncate.c
> index cc83a3f7c1ad..41b8249b3b4a 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -205,7 +205,6 @@ static void truncate_cleanup_page(struct page *page)
>  static int
>  invalidate_complete_page(struct address_space *mapping, struct page *page)
>  {
> -       int ret;
>
>         if (page->mapping != mapping)
>                 return 0;
> @@ -213,9 +212,7 @@ invalidate_complete_page(struct address_space *mapping, struct page *page)
>         if (page_has_private(page) && !try_to_release_page(page, 0))
>                 return 0;
>
> -       ret = remove_mapping(mapping, page);
> -
> -       return ret;
> +       return remove_mapping(mapping, page);
>  }
>
>  int truncate_inode_page(struct address_space *mapping, struct page *page)

 Reviewed-by: Pankaj Gupta <pankaj.gupta@xxxxxxxxx>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux