On 12/5/21 11:58 PM, Christoph Hellwig wrote: > On Fri, Dec 03, 2021 at 08:38:29AM -0700, Jens Axboe wrote: >> Don't call into generic_file_read_iter() if we know it's O_DIRECT, just >> set it up ourselves and call our own handler. This avoids an indirect call >> for O_DIRECT. >> >> Fall back to filemap_read() if we fail. > > Please also do it for the write side, having a partial ->direct_IO is a > really bad idea. Sure, I'll do the write side as well. -- Jens Axboe