Hi Joao, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Joao-Martins/mm-device-dax-Introduce-compound-pages-in-devmap/20211203-044722 base: https://github.com/hnaz/linux-mm master config: i386-randconfig-a013-20211202 (https://download.01.org/0day-ci/archive/20211203/202112031508.uJvmXK7U-lkp@xxxxxxxxx/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/ca6ce8fa76f139a8d4021fc95ce7ba1ebb7a06e2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Joao-Martins/mm-device-dax-Introduce-compound-pages-in-devmap/20211203-044722 git checkout ca6ce8fa76f139a8d4021fc95ce7ba1ebb7a06e2 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/dax/device.c: In function 'dev_dax_huge_fault': >> drivers/dax/device.c:246:8: error: too few arguments to function '__dev_dax_pud_fault' 246 | rc = __dev_dax_pud_fault(dev_dax, vmf); | ^~~~~~~~~~~~~~~~~~~ drivers/dax/device.c:218:19: note: declared here 218 | static vm_fault_t __dev_dax_pud_fault(struct dev_dax *dev_dax, | ^~~~~~~~~~~~~~~~~~~ drivers/dax/device.c: At top level: drivers/dax/device.c:394:5: warning: no previous prototype for 'dev_dax_probe' [-Wmissing-prototypes] 394 | int dev_dax_probe(struct dev_dax *dev_dax) | ^~~~~~~~~~~~~ vim +/__dev_dax_pud_fault +246 drivers/dax/device.c 224 225 static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, 226 enum page_entry_size pe_size) 227 { 228 struct file *filp = vmf->vma->vm_file; 229 vm_fault_t rc = VM_FAULT_SIGBUS; 230 int id; 231 struct dev_dax *dev_dax = filp->private_data; 232 233 dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) size = %d\n", current->comm, 234 (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", 235 vmf->vma->vm_start, vmf->vma->vm_end, pe_size); 236 237 id = dax_read_lock(); 238 switch (pe_size) { 239 case PE_SIZE_PTE: 240 rc = __dev_dax_pte_fault(dev_dax, vmf); 241 break; 242 case PE_SIZE_PMD: 243 rc = __dev_dax_pmd_fault(dev_dax, vmf); 244 break; 245 case PE_SIZE_PUD: > 246 rc = __dev_dax_pud_fault(dev_dax, vmf); 247 break; 248 default: 249 rc = VM_FAULT_SIGBUS; 250 } 251 252 dax_read_unlock(id); 253 254 return rc; 255 } 256 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
