Re: [linux-next:master 3963/4921] arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared; did you mean 'proc_ops'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2 Dec 2021 17:03:39 +0800 kernel test robot <lkp@xxxxxxxxx> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   9606f9efb1cec7f8f5912326f182fbfbcad34382
> commit: aad102cc51173ded2de33a5cae26ace158de5617 [3963/4921] proc: Make the proc_create[_data]() stubs static inlines
> config: sparc-randconfig-r034-20211202 (https://download.01.org/0day-ci/archive/20211202/202112021611.fSXit1xd-lkp@xxxxxxxxx/config)
> compiler: sparc-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=aad102cc51173ded2de33a5cae26ace158de5617
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout aad102cc51173ded2de33a5cae26ace158de5617
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash arch/sparc/kernel/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/sparc/kernel/led.c: In function 'led_init':
> >> arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared (first use in this function); did you mean 'proc_ops'?
>      125 |         led = proc_create("led", 0, NULL, &led_proc_ops);
>          |                                            ^~~~~~~~~~~~
>          |                                            proc_ops
>    arch/sparc/kernel/led.c:125:44: note: each undeclared identifier is reported only once for each function it appears in

Thanks.  I did this.

--- a/arch/sparc/kernel/led.c~proc-make-the-proc_create-stubs-static-inlines-fix2
+++ a/arch/sparc/kernel/led.c
@@ -122,10 +122,11 @@ static int __init led_init(void)
 {
 	timer_setup(&led_blink_timer, led_blink, 0);
 
+#ifdef CONFIG_PROC_FS
 	led = proc_create("led", 0, NULL, &led_proc_ops);
 	if (!led)
 		return -ENOMEM;
-
+#endif
 	printk(KERN_INFO
 	       "led: version %s, Lars Kotthoff <metalhead@xxxxxxxxxxxx>\n",
 	       LED_VERSION);
_





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux