On Fri, Dec 16, 2011 at 03:37:16PM -0800, Andrew Morton wrote: > On Wed, 14 Dec 2011 15:41:22 +0000 > Mel Gorman <mgorman@xxxxxxx> wrote: > > > Short summary: There are severe stalls when a USB stick using VFAT > > is used with THP enabled that are reduced by this series. If you are > > experiencing this problem, please test and report back and considering > > I have seen complaints from openSUSE and Fedora users on this as well > > as a few private mails, I'm guessing it's a widespread issue. This > > is a new type of USB-related stall because it is due to synchronous > > compaction writing where as in the past the big problem was dirty > > pages reaching the end of the LRU and being written by reclaim. > > Overall footprint: > > fs/btrfs/disk-io.c | 5 > fs/hugetlbfs/inode.c | 3 > fs/nfs/internal.h | 2 > fs/nfs/write.c | 4 > include/linux/fs.h | 11 +- > include/linux/migrate.h | 23 +++- > include/linux/mmzone.h | 4 > include/linux/vm_event_item.h | 1 > mm/compaction.c | 5 > mm/memory-failure.c | 2 > mm/memory_hotplug.c | 2 > mm/mempolicy.c | 2 > mm/migrate.c | 171 +++++++++++++++++++++----------- > mm/page_alloc.c | 50 +++++++-- > mm/swap.c | 74 ++++++++++++- > mm/vmscan.c | 114 ++++++++++++++++++--- > mm/vmstat.c | 2 > 17 files changed, 371 insertions(+), 104 deletions(-) > > The line count belies the increase in complexity. > I know and I regret that. Unfortunately while I considered other solutions that were less complex, they were also nowhere near as effective. The theme is at least consistent in that we are continuing to move away from calling writepage in reclaim context. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>