On Thu 25-11-21 21:03:23, Uladzislau Rezki wrote: > On Thu, Nov 25, 2021 at 08:24:04PM +0100, Michal Hocko wrote: > > On Thu 25-11-21 19:02:09, Uladzislau Rezki wrote: > > [...] > > > Therefore i root for simplification and OOM related concerns :) But > > > maybe there will be other opinions. > > > > I have to say that I disagree with your view. I am not sure we have > > other precedence where an allocator would throw away the primary > > allocation just because a metadata allocation failure. > > > Well, i tried to do some code review and raised some concerns and > proposals. I do appreciate your review! No question about that. I was just surprised by your reaction that your review feedback had been ignored because I do not think this is the case. We were in a disagreement and that is just fine. It is quite normal to disagree. The question is whether that disagreement is fundamental and poses a roadblock for merging. I definitely do not want and mean to push anything by force. My previous understanding was that your concerns are mostly about aesthetics rather than blocking further progress. -- Michal Hocko SUSE Labs
