On Sat, 17 Dec 2011, Michel Lespinasse wrote: > On Sat, Dec 17, 2011 at 4:32 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote: > > If one builds the kernel with -Wempty-body one gets this warning: > > > > mm/memory.c:3432:46: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > > > > due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that > > can sometimes be defined to nothing. > > > > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx> > > Looks good to me. I'd be happy with either that or Al's alternative suggestion. > > Reviewed-by: Michel Lespinasse <walken@xxxxxxxxxx> > Thanks for the review. I did see Al's suggestion and he does have a point. But since it doesn't actually matter much in this specific case I'd say "let's just go with this one - it matches what's done nearly everywhere else". But, If someone disagrees strongly I'll cook up a different patch. :-) -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.