On Wed, 14 Dec 2011 23:14:53 +0800 Tao Ma <tm@xxxxxx> wrote: > From: Tao Ma <boyu.mt@xxxxxxxxxx> > > In trace_mm_vmscan_lru_isolate, we don't output 'file' > information to the trace event and it is a bit inconvenient for the > user to get the real information(like pasted below). > mm_vmscan_lru_isolate: isolate_mode=2 order=0 nr_requested=32 nr_scanned=32 > nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 > > 'active' can be gotten by analyzing mode(Thanks go to Minchan and Mel), > So this patch adds 'file' to the trace event and it now looks like: > mm_vmscan_lru_isolate: isolate_mode=2 order=0 nr_requested=32 nr_scanned=32 > nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 file=0 > > ... > > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1249,7 +1249,7 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, > *scanned = scan; > > trace_mm_vmscan_memcg_isolate(0, nr_to_scan, scan, nr_taken, > - 0, 0, 0, mode); > + 0, 0, 0, mode, file); > > return nr_taken; > } This tracepoint was removed by Johannes's "mm: make per-memcg LRU lists exclusive". > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f54a05b..a444dc0 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1221,7 +1221,7 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan, > nr_to_scan, scan, > nr_taken, > nr_lumpy_taken, nr_lumpy_dirty, nr_lumpy_failed, > - mode); > + mode, file); > return nr_taken; > } So this is the only remaining site for that tracepoint. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>