On 11/8/21 12:16 AM, Muchun Song wrote: > On Mon, Nov 1, 2021 at 11:22 AM Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote: >> >> This series can minimize the overhead of struct page for 2MB HugeTLB pages >> significantly. It further reduces the overhead of struct page by 12.5% for >> a 2MB HugeTLB compared to the previous approach, which means 2GB per 1TB >> HugeTLB. It is a nice gain. Comments and reviews are welcome. Thanks. >> > > Hi, > > Ping guys. Does anyone have any comments or suggestions > on this series? > > Thanks. > I did look over the series earlier. I have no issue with the hugetlb and vmemmap modifications as they are enhancements to the existing optimizations. My primary concern is the (small) increased overhead for the helpers as outlined in your cover letter. Since these helpers are not limited to hugetlb and used throughout the kernel, I would really like to get comments from others with a better understanding of the potential impact. -- Mike Kravetz
