On Tue 13-12-11 17:21:26, Michal Hocko wrote: > On Mon 12-12-11 18:16:27, Ying Han wrote: > > In __mem_cgroup_try_charge() function, the parameter "oom" is passed from the > > caller indicating whether or not the charge should enter memcg oom kill. In > > fact, we should be able to eliminate that by using the existing gfp_mask and > > __GFP_NORETRY flag. > > > > This patch removed the "oom" parameter, and add the __GFP_NORETRY flag into > > gfp_mask for those doesn't want to enter memcg oom. There is no functional > > change for those setting false to "oom" like mem_cgroup_move_parent(), but > > __GFP_NORETRY now is checked for those even setting true to "oom". > > > > The __GFP_NORETRY is used in page allocator to bypass retry and oom kill. I > > believe there is a reason for callers to use that flag, and in memcg charge > > we need to respect it as well. > > What is the reason for this change? Ahh, just noticed the second patch. Give me some time to think about that. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>