On Mon 12-12-11 21:49:18, Hillf Danton wrote:
[...]
> From: Hillf Danton <dhillf@xxxxxxxxx>
> Subject: [PATCH] mm: memcg: keep root group unchanged if fail to create new
>
> If the request is to create non-root group and we fail to meet it, we should
> leave the root unchanged.
>
> Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx>
> Acked-by: Hugh Dickins <hughd@xxxxxxxxxx>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Acked-by: Michal Hocko <mhocko@xxxxxxx>
Thanks
> ---
>
> --- a/mm/memcontrol.c Fri Dec 9 21:57:40 2011
> +++ b/mm/memcontrol.c Mon Dec 12 21:47:14 2011
> @@ -4848,9 +4848,9 @@ mem_cgroup_create(struct cgroup_subsys *
> int cpu;
> enable_swap_cgroup();
> parent = NULL;
> - root_mem_cgroup = memcg;
> if (mem_cgroup_soft_limit_tree_init())
> goto free_out;
> + root_mem_cgroup = memcg;
> for_each_possible_cpu(cpu) {
> struct memcg_stock_pcp *stock =
> &per_cpu(memcg_stock, cpu);
> @@ -4888,7 +4888,6 @@ mem_cgroup_create(struct cgroup_subsys *
> return &memcg->css;
> free_out:
> __mem_cgroup_free(memcg);
> - root_mem_cgroup = NULL;
> return ERR_PTR(error);
> }
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxx. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>