On Thu, Oct 21, 2021 at 09:21:17AM +0200, David Hildenbrand wrote: > On 21.10.21 08:51, Christoph Hellwig wrote: > > FYI, with my block and direct I/O developer hat on I really, really > > want to have the folio for both file and anon pages. Because to make > > the get_user_pages path a _lot_ more efficient it should store folios. > > And to make that work I need them to work for file and anon pages > > because for get_user_pages and related code they are treated exactly > > the same. ++ > Thanks, I can understand that. And IMHO that would be even possible with > split types; the function prototype will simply have to look a little > more fancy instead of replacing "struct page" by "struct folio". :) Possible yes, but might it be a little premature to split them?