Re: [PATCH v2] mm: simplify find_vma_prev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> diff --git a/mm/mmap.c b/mm/mmap.c
> []
>> @@ -1603,39 +1603,21 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
>>
>>  EXPORT_SYMBOL(find_vma);
>>
>> -/* Same as find_vma, but also return a pointer to the previous VMA in *pprev. */
>> +/*
>> + * Same as find_vma, but also return a pointer to the previous VMA in *pprev.
>> + * Note: pprev is set to NULL when return value is NULL.
>> + */
>>  struct vm_area_struct *
>> -find_vma_prev(struct mm_struct *mm, unsigned long addr,
>> -                     struct vm_area_struct **pprev)
>
>> +find_vma_prev(struct mm_struct *mm, unsigned long addr, struct vm_area_struct **pprev)
>
> eh.  This declaration change seems gratuitous and it exceeds 80 columns.
>
>> +     *pprev = NULL;
>> +     vma = find_vma(mm, addr);
>> +     if (vma)
>> +             *pprev = vma->vm_prev;
>
> There's no need to possibly set *pprev twice.
>
> Maybe
> {
>        struct vm_area_struct *vma = find_vma(mm, addr);
>
>        *pprev = vma ? vma->vm_prev : NULL;
> or
>        if (vma)
>                *pprev = vma->vm_prev;
>        else
>                *pprev = NULL;
>
>        return vma;

Thank you for reviewing. Updated.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]