This changes the (undocumented, naturally) interface in disturbing ways. Currently, *pprev will always be written to. With this change, *pprev will only be written to if find_vma_prev() returns non-NULL. Looking through the code, this is mostly benign. But it will cause the CONFIG_STACK_GROWSUP version of find_extend_vma() to use an uninitialised stack slot in ways which surely will crash the kernel.
Weird.
So please have a think about that and fix it up. And please add documentation for find_vma_prev()'s interface so we don't break it next time.
Sure thing. Thank you for good spotting! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>