On Mon, Oct 18, 2021 at 5:23 AM Chen Wandun <chenwandun@xxxxxxxxxx> wrote:
>
[...]
>
> /* High-order pages or fallback path if "bulk" fails. */
> - while (nr_allocated < nr_pages) {
> - struct page *page;
> - int i;
>
> - page = alloc_pages_node(nid, gfp, order);
> + page = NULL;
No need for the above NULL assignment.
After removing this, you can add:
Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
> + while (nr_allocated < nr_pages) {
> + if (nid == NUMA_NO_NODE)
> + page = alloc_pages(gfp, order);
> + else
> + page = alloc_pages_node(nid, gfp, order);
> if (unlikely(!page))
> break;
>
> --
> 2.25.1
>
