On 10/13/21 2:57 PM, Kirill A. Shutemov wrote:
> On Wed, Oct 13, 2021 at 01:22:10PM +0800, Yafang Shao wrote:
>> On Wed, Oct 13, 2021 at 2:33 AM Matthew Wilcox (Oracle)
>> <willy@xxxxxxxxxxxxx> wrote:
>>>
>>> Instead of calling snprintf(), just append '|' by hand.
>>>
>>> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
>>> ---
>>> lib/test_printf.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/lib/test_printf.c b/lib/test_printf.c
>>> index 60cdf4ba991e..662c3785aa57 100644
>>> --- a/lib/test_printf.c
>>> +++ b/lib/test_printf.c
>>> @@ -623,9 +623,9 @@ page_flags_test(int section, int node, int zone, int last_cpupid,
>>> if (!pft[i].width)
>>> continue;
>>>
>>> - if (append) {
>>> - snprintf(cmp_buf + size, BUF_SIZE - size, "|");
>>> - size = strlen(cmp_buf);
>>> + if (append && size < BUF_SIZE) {
>>
>> Should it be:
>> if (append && size < BUF_SIZE - 1)
>> ?
>
> Yeah, looks like off-by-one to me.
Agreed.
