On Mon, Dec 05, 2011 at 04:54:34PM +0100, Ingo Molnar wrote: > > * Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > > > On Mon, Dec 05, 2011 at 12:06:56PM +0100, Ingo Molnar wrote: > > > > > > * Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > > > > > > > When (no)bootmem finish operation, it pass pages to buddy allocator. > > > > Since debug_pagealloc_enabled is not set, we will do not protect pages, > > > > what is not what we want with CONFIG_DEBUG_PAGEALLOC=y. > > > > > > > > To fix remove debug_pagealloc_enabled. That variable was introduced by > > > > commit 12d6f21e "x86: do not PSE on CONFIG_DEBUG_PAGEALLOC=y" to get > > > > more CPA (change page attribude) code testing. But currently we have > > > > CONFIG_CPA_DEBUG, which test CPA. > > > > > > > > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > > > Acked-by: Mel Gorman <mgorman@xxxxxxx> > > > > --- > > > > arch/x86/mm/pageattr.c | 6 ------ > > > > include/linux/mm.h | 10 ---------- > > > > init/main.c | 5 ----- > > > > mm/debug-pagealloc.c | 3 --- > > > > 4 files changed, 0 insertions(+), 24 deletions(-) > > > > > > I'm getting this boot crash with the patch applied: > > > > I'm sorry for breaking the boot. I tried to reproduce problem > > on my laptop, but failed. I plan to test patch with your > > config on some other machines. > > > > On the meantime can you test attached incremental patch and > > see if it workaround the crash? I suspect memblock reuse pages > > that it passed already to buddy allocator. > > That will take some time - so if you could try my config on > another box that would be great. There isnt anything special > about that box. I reproduced with limiting memory via mem=1G and increase find_range_array count argument, what caused "struct range" array was bigger and needed more memory. With that I can confirm that previous patch fixes the problem. I think it's the simplest possible fix, I'll post patch with changelog and comment in the next email. Stanislaw -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>