On Thu, Oct 7, 2021 at 9:14 AM Peter Xu <peterx@xxxxxxxxxx> wrote: > > On Wed, Oct 06, 2021 at 04:41:35PM -0700, Yang Shi wrote: > > > Or maybe we just don't touch it until there's need for a functional change? I > > > feel it a pity to lose the git blame info for reindent-only patches, but no > > > strong opinion, because I know many people don't think the same and I'm fine > > > with either ways. > > > > TBH I really don't think keeping old "git blame" info should be an > > excuse to avoid any coding style cleanup. > > Sure. > > > > > > > > > Another side note: perhaps a comment above pageflags enum on PG_has_hwpoisoned > > > would be nice? I saw that we've got a bunch of those already. > > > > I was thinking about that, but it seems PG_double_map doesn't have > > comment there either so I didn't add. > > IMHO that means we may just need even more documentations? :) > > I won't ask for documenting doublemap bit in this series, but I just don't > think it's a good excuse to not provide documentations if we still can. > Especially to me PageHasHwpoisoned looks really so like PageHwpoisoned, so > it'll be still very nice to have some good document along with the patch it's > introduced. OK, I could add more comments for this flag in the enum. It should be just a duplicate of the comment right before the PAGEFLAG definition. > > Thanks, > > -- > Peter Xu >
