Hi Waiman, I love your patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Waiman-Long/mm-memcg-Miscellaneous-cleanups/20211002-031125 base: https://github.com/hnaz/linux-mm master config: x86_64-randconfig-a016-20211001 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 962e503cc8bc411f7523cc393acae8aae425b1c4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/321484dcb4f16ca7bd626adf390222913d188ecc git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Waiman-Long/mm-memcg-Miscellaneous-cleanups/20211002-031125 git checkout 321484dcb4f16ca7bd626adf390222913d188ecc # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> mm/memcontrol.c:2225:22: error: no member named 'kmem_state' in 'struct mem_cgroup' if (unlikely(memcg->kmem_state != KMEM_ONLINE)) { ~~~~~ ^ include/linux/compiler.h:78:42: note: expanded from macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ 1 error generated. vim +2225 mm/memcontrol.c 2212 2213 /* 2214 * Cache charges(val) to local per_cpu area. 2215 * This will be consumed by consume_stock() function, later. 2216 */ 2217 static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) 2218 { 2219 struct memcg_stock_pcp *stock; 2220 unsigned long flags; 2221 2222 /* 2223 * An offlined memcg shouldn't be put into stock. 2224 */ > 2225 if (unlikely(memcg->kmem_state != KMEM_ONLINE)) { 2226 cancel_charge(memcg, nr_pages); 2227 return; 2228 } 2229 2230 local_irq_save(flags); 2231 2232 stock = this_cpu_ptr(&memcg_stock); 2233 if (stock->cached != memcg) { /* reset if necessary */ 2234 drain_stock(stock); 2235 css_get(&memcg->css); 2236 stock->cached = memcg; 2237 } 2238 stock->nr_pages += nr_pages; 2239 2240 if (stock->nr_pages > MEMCG_CHARGE_BATCH) 2241 drain_stock(stock); 2242 2243 local_irq_restore(flags); 2244 } 2245 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
