Re: [PATCH 03/16] include: move find.h from asm_generic to linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 02, 2021 at 11:23:26AM +0200, Geert Uytterhoeven wrote:
> Hi Yuri,
> 
> Thanks for your patch!
> 
> On Fri, Oct 1, 2021 at 8:12 PM Yury Norov <yury.norov@xxxxxxxxx> wrote:
> > find_bit API and bitmap API are closely related, but inclusion paths
> > are different - include/asm-generic and include/linux, correspondingly.
> > In the past it made a lot of troubles due to circular dependencies
> > and/or undefined symbols. Fix this by moving find.h under include/linux.
> 
> .. and including it from include/linux/bitmap.h, like the other helper includes?

yes.

> > Signed-off-by: Yury Norov <yury.norov@xxxxxxxxx>
> > Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> 
> >  arch/m68k/include/asm/bitops.h               |  2 --
> 
> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> 
> > --- a/include/linux/bitmap.h
> > +++ b/include/linux/bitmap.h
> > @@ -6,6 +6,7 @@
> >
> >  #include <linux/align.h>
> >  #include <linux/bitops.h>
> > +#include <linux/find.h>
> >  #include <linux/limits.h>
> >  #include <linux/string.h>
> >  #include <linux/types.h>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux