On Thu, Sep 30, 2021 at 06:27:15PM -0700, Joe Perches wrote: > On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote: > > Hi Joe, > > > > On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote: > > > Use more typical kernel logging styles. > > > > > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt > > > > I don't see it as an improvement. On the contrary, the output becomes > > somewhat tautological: > > And rather easier to grep as the prefix is constant. memblock_ is perfectly greppable -- Sincerely yours, Mike.