Re: [RFC v2 PATCH 1/3] mm: add PG2KB/KB2PG helper macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
Subject: Re: [RFC v2 PATCH 1/3] mm: add PG2KB/KB2PG helper macros
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Sun, 19 Sep 2021 15:21:37 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Miaohe Lin <linmiaohe@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, David Laight <David.Laight@xxxxxxxxxx>
In-reply-to: <20210919131248.489798-2-oleksandr@natalenko.name>
References: <20210919131248.489798-1-oleksandr@natalenko.name> <20210919131248.489798-2-oleksandr@natalenko.name>

On Sun, Sep 19, 2021 at 03:12:46PM +0200, Oleksandr Natalenko wrote:
> +#define PG2KB(x)	((x) << (PAGE_SHIFT - 10))
> +#define KB2PG(x)	((x) >> (PAGE_SHIFT - 10))

This is not an improvement.

References:
- [RFC v2 PATCH 0/3] mm: common PAGE_SIZE shift macros
  - From: Oleksandr Natalenko
- [RFC v2 PATCH 1/3] mm: add PG2KB/KB2PG helper macros
  - From: Oleksandr Natalenko

Prev by Date: Re: [RFC v2 PATCH 1/3] mm: add PG2KB/KB2PG helper macros
Next by Date: Re: [PATCH] fs: buffer: check huge page size instead of single page for invalidatepage
Previous by thread: Re: [RFC v2 PATCH 1/3] mm: add PG2KB/KB2PG helper macros
Next by thread: [RFC v2 PATCH 2/3] mm: replace custom PG2KB/KB2PG macros with common ones
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux