On Thu, Sep 16, 2021 at 03:57:38PM -0700, John Hubbard wrote: > On 9/16/21 14:28, Peter Xu wrote: > > Drop it in the header since it's only used in hugetlb.c. > > Hi Peter, Hi, John, > > Tiny documentation tweak: could the above line please be changed to > something approximately like this: > > "Remove __unmap_hugepage_range() from the header file, because it is > only used in the .c file." > > ? Sure thing. > > Because: "drop it in" is so close to "drop it into" (which means, "add > it to"), that it's actually reading a lot like the opposite of what you > intend to say. > > > > > Suggested-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> > > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx> > > --- > > include/linux/hugetlb.h | 10 ---------- > > mm/hugetlb.c | 6 +++--- > > 2 files changed, 3 insertions(+), 13 deletions(-) > > > The change itself looks accurate for the current top of tree, so: > > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx> Thanks! -- Peter Xu
