On Tue, 7 Sep 2021 13:52:04 -0700 Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:
> On 9/4/21 12:54 AM, zhangyiru wrote:
> > remove mlock ulimit for SHM_HUGETLB
> > commit 21a3c273f88c9cbbaf7e ("mm, hugetlb: add thread name and pid to
> > SHM_HUGETLB mlock rlimit warning") marked this as deprecated in 2012,
> > but it is not deleted yet
>
> A better commit to mention would be 2584e517320b ("mm: reintroduce and
> deprecate rlimit based access for SHM_HUGETLB"). IIUC, 21a3c273f88c just
> modified the log message.
I made that change to the changelog.
> There is nothing wrong with the code. Adding Andrew and Michal on Cc:
> as I have little or no experience with removing deprecated
> features/code. This certainly has been marked deprecated for a long
> time (since 2.6.31).
I'd have thought that emitting a nasty message for a decade would suffice.
> However, I still see that message in log files on
> occasion.
However I appear to be wrong :(
A quick web search indicates that people were reporting this in 2020,
at least. So I don't think we can remove it.
otoh, one report was against RHEL3 which went end-of-life in 2015. So
perhaps some more research on this will end up making the justifiable.
I dunno, I'm just waffling. Maybe just merge it and if someone
complains, they can't say they weren't warned!
