On Wed, Sep 15, 2021 at 4:23 AM Theodore Ts'o <tytso@xxxxxxx> wrote: > > On Tue, Sep 14, 2021 at 03:28:22PM +0800, Muchun Song wrote: > > So we have to convert to new API for all filesystems, which is done in > > one patch. Some filesystems are easy to convert (just replace > > kmem_cache_alloc() to alloc_inode_sb()), while other filesystems need to > > do more work. > > From what I can tell, three are 54 file systems for which it was a > trivial one-line change, and two (f2fs and nfs42) that were a tad bit > more complex. Definitely right. Thanks for your clarification. > > > In order to make it easy for maintainers of different > > filesystems to review their own maintained part, I split the patch into > > patches which are per-filesystem in this version. I am not sure if this > > is a good idea, because there is going to be more commits. > > What I'd actually suggest is that you combine all of the trivial file > system changes into a single commit, and keep the two more complex > changes for f2fs and nfs42 in separate commits. Got it. Will do in the next version. > > Acked-by: Theodore Ts'o <tytso@xxxxxxx> Thanks. > > ... for the ext4 related change. > > - Ted >
