On Tue, Sep 14, 2021 at 12:00 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > Note, they do fix a real bug as shown by: > > https://lore.kernel.org/all/e5c7ce5b-93f0-b305-de32-c99d0390eb28@xxxxxxx/ Ok, can you send me that NULL ptr check as one separate thing? > Should we hold off until mm has fixed this issue? Yeah. That would actually fix the NULL pointer issue too, since a _proper_ memblock_free() would just be a no-op for NULL. That whole "do __pa() on a random pointer to pass it to memblock_free()" is really just complete garbage in _so_ many ways. Linus
