Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Liam Howlett <liam.howlett@xxxxxxxxxx>
Subject: Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Thu, 9 Sep 2021 10:05:29 +0200
Cc: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Luigi Rizzo <lrizzo@xxxxxxxxxx>, Yonghong Song <yhs@xxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, bpf <bpf@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, "kernel-team@xxxxxx" <kernel-team@xxxxxx>, "walken@xxxxxx" <walken@xxxxxx>
In-reply-to: <20210908183032.zoh6dj5xh455z47f@revolver>
References: <CAMOZA0+FofdYMivrBR14snb6Xo_i6BV7gVX1dGCtJa=ue3VqEQ@mail.gmail.com> <20210908151230.m2zyslt4qrufm4bv@revolver> <f5328a05-ed3c-a868-9240-1b0852e01406@fb.com> <CAMOZA0+2KLgYTXDZHGUYFnYezee=_hH6kFVM+-n2ZQuFTfh6yg@mail.gmail.com> <20210908172118.n2f4w7epm6hh62zf@ast-mbp.dhcp.thefacebook.com> <20210908105259.c47dcc4e4371ebb5e147ee6e@linux-foundation.org> <20210908180258.yjh62e5oouckar5b@ast-mbp.dhcp.thefacebook.com> <20210908111527.9a611426e257d55ccbbf46eb@linux-foundation.org> <CAADnVQ+5m0+X1Xvgu-wYii2nWvAtEfk2ffM6mQTaiq2SPM1Z=A@mail.gmail.com> <20210908183032.zoh6dj5xh455z47f@revolver>

On Wed, Sep 08, 2021 at 06:30:52PM +0000, Liam Howlett wrote:
> +	VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm);

NAK.. do not ever use the _is_locked() trainwrecks.

References:
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Luigi Rizzo
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Liam Howlett
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Yonghong Song
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Luigi Rizzo
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Alexei Starovoitov
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Andrew Morton
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Alexei Starovoitov
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Andrew Morton
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Alexei Starovoitov
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Liam Howlett

Prev by Date: Re: [PATCH v2] fix judgment error in shmem_is_huge()
Next by Date: RE: [patch 102/147] lib/string: optimized memmove
Previous by thread: Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
Next by thread: Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]