On Mon, Sep 06, 2021 at 09:20:35PM +0100, Matthew Wilcox wrote: > On Mon, Sep 06, 2021 at 03:46:34PM +0000, Chuck Lever III wrote: > > Hi Neil- > > > > > On Sep 6, 2021, at 12:44 AM, NeilBrown <neilb@xxxxxxx> wrote: > > > > > > > > > Many places that need to wait before retrying a memory allocation use > > > congestion_wait(). xfs_buf_alloc_pages() is a good example which > > > follows a similar pattern to that in svc_alloc_args(). > > > > > > It make sense to do the same thing in svc_alloc_args(); This will allow > > > the allocation to be retried sooner if some backing device becomes > > > non-congested before the timeout. > > It's adorable that you believe this is still true. > > https://lore.kernel.org/linux-mm/20191231125908.GD6788@xxxxxxxxxxxxxxxxxxxxxx/ So, what's the advice for now? Do we add the congestion_wait() call anyway and assume it'll be fixed to do something less broken in the future, or just skip it completely? --b.
