Re: [PATCH] MIPS: fix local_t operation on MIPS64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Huang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.14 next-20210903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huang-Pei/MIPS-fix-local_t-operation-on-MIPS64/20210904-231410
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f1583cb1be35c23df60b1c39e3e7e6704d749d0b
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4a1c6e12f6f078dfc5351925656b237f7e5fbb50
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huang-Pei/MIPS-fix-local_t-operation-on-MIPS64/20210904-231410
        git checkout 4a1c6e12f6f078dfc5351925656b237f7e5fbb50
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from arch/mips/include/asm/local.h:8,
                    from include/linux/genhd.h:20,
                    from include/linux/blkdev.h:8,
                    from include/linux/blk-cgroup.h:23,
                    from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/net/sock.h:53,
                    from include/linux/tcp.h:19,
                    from drivers/net/slip/slip.c:91:
   arch/mips/include/asm/asm.h:68: warning: "END" redefined
      68 | #define END(function)                                   \
         | 
   In file included from drivers/net/slip/slip.c:88:
   drivers/net/slip/slip.h:44: note: this is the location of the previous definition
      44 | #define END             0300            /* indicates end of frame       */
         | 
   drivers/net/slip/slip.c: In function 'slip_esc':
>> drivers/net/slip/slip.c:930:18: error: 'END' undeclared (first use in this function)
     930 |         *ptr++ = END;
         |                  ^~~
   drivers/net/slip/slip.c:930:18: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/slip/slip.c: In function 'slip_unesc':
   drivers/net/slip/slip.c:960:14: error: 'END' undeclared (first use in this function)
     960 |         case END:
         |              ^~~
   drivers/net/slip/slip.c: In function 'sl_outfill':
   drivers/net/slip/slip.c:1393:75: error: 'END' undeclared (first use in this function)
    1393 |                         unsigned char s = (sl->mode & SL_MODE_SLIP6)?0x70:END;
         |                                                                           ^~~


vim +/END +930 drivers/net/slip/slip.c

^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  909  
5342b77c4123ba39 drivers/net/slip.c Alan Cox       2009-09-19  910  static int slip_hangup(struct tty_struct *tty)
5342b77c4123ba39 drivers/net/slip.c Alan Cox       2009-09-19  911  {
5342b77c4123ba39 drivers/net/slip.c Alan Cox       2009-09-19  912  	slip_close(tty);
5342b77c4123ba39 drivers/net/slip.c Alan Cox       2009-09-19  913  	return 0;
5342b77c4123ba39 drivers/net/slip.c Alan Cox       2009-09-19  914  }
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  915   /************************************************************************
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  916    *			STANDARD SLIP ENCAPSULATION		  	 *
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  917    ************************************************************************/
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  918  
9ce6cf25538de803 drivers/net/slip.c Alan Cox       2007-11-19  919  static int slip_esc(unsigned char *s, unsigned char *d, int len)
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  920  {
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  921  	unsigned char *ptr = d;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  922  	unsigned char c;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  923  
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  924  	/*
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  925  	 * Send an initial END character to flush out any
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  926  	 * data that may have accumulated in the receiver
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  927  	 * due to line noise.
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  928  	 */
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  929  
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16 @930  	*ptr++ = END;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  931  
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  932  	/*
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  933  	 * For each byte in the packet, send the appropriate
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  934  	 * character sequence, according to the SLIP protocol.
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  935  	 */
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  936  
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  937  	while (len-- > 0) {
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  938  		switch (c = *s++) {
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  939  		case END:
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  940  			*ptr++ = ESC;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  941  			*ptr++ = ESC_END;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  942  			break;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  943  		case ESC:
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  944  			*ptr++ = ESC;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  945  			*ptr++ = ESC_ESC;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  946  			break;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  947  		default:
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  948  			*ptr++ = c;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  949  			break;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  950  		}
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  951  	}
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  952  	*ptr++ = END;
807540baae406c84 drivers/net/slip.c Eric Dumazet   2010-09-23  953  	return ptr - d;
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  954  }
^1da177e4c3f4152 drivers/net/slip.c Linus Torvalds 2005-04-16  955  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux