Re: [PATCH v2 0/7] Remove in-tree usage of MAP_DENYWRITE

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: linux-kernel@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

Subject: Re: [PATCH v2 0/7] Remove in-tree usage of MAP_DENYWRITE

From: David Hildenbrand <david@xxxxxxxxxx>

Date: Fri, 3 Sep 2021 11:45:01 +0200

Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Petr Mladek <pmladek@xxxxxxxx>, Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Greg Ungerer <gerg@xxxxxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Vincenzo Frascino <vincenzo.frascino@xxxxxxx>, Chinwen Chang <chinwen.chang@xxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, Huang Ying <ying.huang@xxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Feng Tang <feng.tang@xxxxxxxxx>, Kevin Brodsky <Kevin.Brodsky@xxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Shawn Anastasio <shawn@xxxxxxxxxx>, Steven Price <steven.price@xxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christian Brauner <christian.brauner@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, Marco Elver <elver@xxxxxxxxxx>, Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>, Nicolas Viennot <Nicolas.Viennot@xxxxxxxxxxxx>, Thomas Cedeno <thomascedeno@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Chengguang Xu <cgxu519@xxxxxxxxxxxx>, Christian König <ckoenig.leichtzumerken@xxxxxxxxx>, Florian Weimer <fweimer@xxxxxxxxxx>, David Laight <David.Laight@xxxxxxxxxx>, linux-unionfs@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx

In-reply-to: <20210816194840.42769-1-david@redhat.com>

Organization: Red Hat

References: <20210816194840.42769-1-david@redhat.com>

User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 16.08.21 21:48, David Hildenbrand wrote:

This series removes all in-tree usage of MAP_DENYWRITE from the kernel
and removes VM_DENYWRITE. We stopped supporting MAP_DENYWRITE for
user space applications a while ago because of the chance for DoS.
The last renaming user is binfmt binary loading during exec and
legacy library loading via uselib().

So, how do we want to continue with this? Pick it up for v5.15? Have itin -next for a while and eventually pick it up for v5.16?

I think the "remove ETXTBSY completely" and "remove the sanity mappingcheck" thingies should be done on top.


--
Thanks,

David / dhildenb