Hi Hillf, On Fri, Nov 25, 2011 at 08:20:31PM +0800, Hillf Danton wrote: > Skip unlocking page if fail to lock, then lock and unlock are paired. > > Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx> > --- > > --- a/mm/migrate.c Fri Nov 25 20:11:14 2011 > +++ b/mm/migrate.c Fri Nov 25 20:21:26 2011 > @@ -869,9 +869,9 @@ static int unmap_and_move_huge_page(new_ > > if (anon_vma) > put_anon_vma(anon_vma); > -out: > unlock_page(hpage); > > +out: > if (rc != -EAGAIN) { > list_del(&hpage->lru); > put_page(hpage); Looks good, I guess that path wasn't exercised frequently because there's no blocking I/O involvement with hugetlbfs. Thanks, Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>