On Fri, 2011-11-18 at 16:38 +0530, Srikar Dronamraju wrote: > + /* poke the new insn in, ASSUMES we don't cross page boundary */ > + vaddr &= ~PAGE_MASK; > + memcpy(vaddr_new + vaddr, &opcode, uprobe_opcode_sz); I still don't get why you don't simply write something like: BUG_ON(vaddr + uprobe_opcode_size >= PAGE_SIZE); That's as descriptive as the comment and actually does something if someone got it wrong, instead of silently corrupting crap. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>