On Wed 01-09-21 11:21:49, Oleksandr Natalenko wrote: > There are various places where the K(x) macro is defined. This commit > gets rid of multiple definitions and provides a common one. > > This doesn't solve open-coding this macro in various other places. This > should be addressed by another subsequent commit. Why is this an improvement? You are adding a header file for a single macro which sounds like an overkill. The overall net outcome is added lines of code. It is not like K() or any of its variant is adding a maintenance burden due to code duplication. So why do we want to change the existing state? -- Michal Hocko SUSE Labs