On Fri, Aug 27, 2021 at 01:28:52PM -0300, Jason Gunthorpe wrote: > > + /* > > + * just bypass devmap pte such as DAX page when all pfn requested > > + * flags(pfn_req_flags) are fulfilled. > > + */ > > + if (pte_devmap(pte)) > > + goto out; > > I liked your ealier version better where this was added to the > pte_special test - logically this is about disambiguating the > pte_special and the devmap case as they are different things. Yes, I think that is much more logical. Also please capitalize the first word in multi-line comments.
