> On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote:
> > +int register_uprobe(struct inode *inode, loff_t offset,
> > + struct uprobe_consumer *consumer)
> > +{
> > + struct uprobe *uprobe;
> > + int ret = -EINVAL;
> > +
> > + if (!consumer || consumer->next)
> > + return ret;
> > +
> > + inode = igrab(inode);
>
> So why are you dealing with !consumer but not with !inode? and why
> does
> it make sense to allow !consumer at all?
>
I am not sure if I got your comment correctly.
I do check for inode just after the igrab.
I am actually not dealing with !consumer.
If the consumer is NULL, then we dont have any handler to run so why
would we want to register such a probe?
Also if consumer->next is Non-NULL, that means that this consumer was
already used. Reusing the consumer, can result in consumers list getting
broken into two.
If you meant something else please clarify.
--
Thanks and Regards
Srikar
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>