On Wed, Nov 23, 2011 at 9:59 PM, KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: >> + >> + goto unlock; >> + >> +undo: >> + while (index > start) { >> + shmem_truncate_page(inode, index); >> + index--; > > Hmmm... > seems too aggressive truncate if the file has pages before starting fallocate. > but I have no idea to make better undo. ;) Why do we need to undo anyway? Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href