On Wed, Aug 18, 2021 at 09:24:01AM +0200, David Hildenbrand wrote: ... > > Might we want to add a TODO in the code? We have a similar one in > mm/page_isolation.c:set_migratetype_isolate() and it's certainly a reminder > that something of value is missing. Yes, that will be helpful. The below's what's in my mind, but if someone has better idea, that's fine. @@ -296,11 +296,9 @@ void shake_page(struct page *p, int access) } /* - * Only call shrink_node_slabs here (which would also shrink - * other caches) if access is not potentially fatal. + * TODO: Could shrink slab caches here if a lightweight range-based + * shrinker will be available. */ - if (access) - drop_slab_node(page_to_nid(p)); } EXPORT_SYMBOL_GPL(shake_page); - Naoya Horiguchi
