Re: [PATCH] remap_file_pages: Use vma_lookup() instead of find_vma()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17.08.21 15:52, Liam Howlett wrote:
From: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>

Using vma_lookup() verifies the start address is contained in the found vma.
This results in easier to read code.

Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
---
  mm/mmap.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index d9aa54be6244..1a23d4575cc4 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2994,14 +2994,11 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
  	if (mmap_write_lock_killable(mm))
  		return -EINTR;
- vma = find_vma(mm, start);
+	vma = vma_lookup(mm, start);
if (!vma || !(vma->vm_flags & VM_SHARED))
  		goto out;
- if (start < vma->vm_start)
-		goto out;
-
  	if (start + size > vma->vm_end) {
  		struct vm_area_struct *next;

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux