From: kernel test robot <lkp@xxxxxxxxx> drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 7ebb336e45ef ("scsi: qla2xxx: edif: Add start + stop bsgs") CC: Quinn Tran <qutran@xxxxxxxxxxx> Reported-by: kernel test robot <lkp@xxxxxxxxx> Signed-off-by: kernel test robot <lkp@xxxxxxxxx> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: da454ebf578f6c542ba9f5b3ddb98db3ede109c1 commit: 7ebb336e45ef1ce23462c3bbd03779929008901f [2910/6223] scsi: qla2xxx: edif: Add start + stop bsgs :::::: branch date: 14 hours ago :::::: commit date: 2 weeks ago qla_edif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/scsi/qla2xxx/qla_edif.c +++ b/drivers/scsi/qla2xxx/qla_edif.c @@ -210,7 +210,6 @@ qla_edif_app_start(scsi_qla_host_t *vha, static int qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job) { - int32_t rval = 0; struct app_stop appstop; struct fc_bsg_reply *bsg_reply = bsg_job->reply; struct fc_port *fcport, *tf; @@ -261,7 +260,7 @@ qla_edif_app_stop(scsi_qla_host_t *vha, /* no return interface to app - it assumes we cleaned up ok */ - return rval; + return 0; } int32_t