Re: [rfc 01/18] slub: Get rid of the node field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 20 Nov 2011, David Rientjes wrote:

> On Fri, 11 Nov 2011, Christoph Lameter wrote:
>
> > The node field is always page_to_nid(c->page). So its rather easy to
> > replace. Note that there will be additional overhead in various hot paths
> > due to the need to mask a set of bits in page->flags and shift the
> > result.
> >
>
> This certainly does add overhead to the fastpath just by checking
> node_match() if we're doing kmalloc_node(), and that overhead might be
> higher than you expect if NODE_NOT_IN_PAGE_FLAGS.  Storing the node in
> kmem_cache_cpu was always viewed as an optimization, not sure why you'd
> want to get rid of it?  The changelog at least doesn't mention any
> motivation.  Do we need to shrink that struct for something else later or
> something?

If you would read the description of the patch series you could probably
figure it out.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]