On Fri, 23 Jul 2021 09:59:55 +0200 Paolo Bonzini wrote:
>On 23/07/21 04:23, Hillf Danton wrote:
>> Detect concurrent reader and writer by reading event counter before and
>> after poll_wait(), and determine feedback with the case of unstable
>> counter taken into account.
>>
>> Cut the big comment as the added barriers speak for themselves.
>
>First and foremost, I'm not sure what you are trying to fix.
The change proposed builds the return value without assuming that the
event count is stable across poll_wait(). If it is unstable then we know
there are concurrent reader and/or writer who both are ingnored currently.
>
>Second, the patch is wrong even without taking into account the lockless
>accesses, because the condition for returning EPOLLOUT is certainly wrong.
Given it is detected that event count was consumed, there is room, though
as racy as it is, in the event count for writer to make some progress.
>
>Third, barriers very rarely speak for themselves. In particular what
>do they pair with?
There is no need to consider pair frankly. Barriers are just readded for
removing the seep in the comment. Then the comment goes with the seep.
What the comment does not cover is the cases of more-than-two-party race.
Hillf
>It seems to me that you are basically reintroducing
>the same mistake that commit a484c3dd9426 ("eventfd: document lockless
>access in eventfd_poll", 2016-03-22) fixed, at the time where the big
>comment was introduced:
>
> Things aren't as simple as the read barrier in eventfd_poll
> would suggest. In fact, the read barrier, besides lacking a
> comment, is not paired in any obvious manner with another read
> barrier, and it is pointless because it is sitting between a write
> (deep in poll_wait) and the read of ctx->count.
>
>Paolo
>
>
>> +++ x/fs/eventfd.c
>> @@ -131,49 +131,20 @@ static __poll_t eventfd_poll(struct file
>> {
>> struct eventfd_ctx *ctx = file->private_data;
>> __poll_t events = 0;
>> - u64 count;
>> + u64 c0, count;
>> +
>> + c0 = ctx->count;
>> + smp_rmb();
>>
>> poll_wait(file, &ctx->wqh, wait);
>>
>> - /*
>> - * All writes to ctx->count occur within ctx->wqh.lock. This read
>> - * can be done outside ctx->wqh.lock because we know that poll_wait
>> - * takes that lock (through add_wait_queue) if our caller will sleep.
>> - *
>> - * The read _can_ therefore seep into add_wait_queue's critical
>> - * section, but cannot move above it! add_wait_queue's spin_lock acts
>> - * as an acquire barrier and ensures that the read be ordered properly
>> - * against the writes. The following CAN happen and is safe:
>> - *
>> - * poll write
>> - * ----------------- ------------
>> - * lock ctx->wqh.lock (in poll_wait)
>> - * count = ctx->count
>> - * __add_wait_queue
>> - * unlock ctx->wqh.lock
>> - * lock ctx->qwh.lock
>> - * ctx->count += n
>> - * if (waitqueue_active)
>> - * wake_up_locked_poll
>> - * unlock ctx->qwh.lock
>> - * eventfd_poll returns 0
>> - *
>> - * but the following, which would miss a wakeup, cannot happen:
>> - *
>> - * poll write
>> - * ----------------- ------------
>> - * count = ctx->count (INVALID!)
>> - * lock ctx->qwh.lock
>> - * ctx->count += n
>> - * **waitqueue_active is false**
>> - * **no wake_up_locked_poll!**
>> - * unlock ctx->qwh.lock
>> - * lock ctx->wqh.lock (in poll_wait)
>> - * __add_wait_queue
>> - * unlock ctx->wqh.lock
>> - * eventfd_poll returns 0
>> - */
>> - count = READ_ONCE(ctx->count);
>> + smp_rmb();
>> + count = ctx->count;
>> +
>> + if (c0 < count)
>> + return EPOLLIN;
>> + if (c0 > count)
>> + return EPOLLOUT;
>>
>> if (count > 0)
>> events |= EPOLLIN;
>>
