Re: [RFC PATCH 02/12] netfs: Add an iov_iter to the read subreq for the network fs/cache to use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jeff Layton <jlayton@xxxxxxxxxx>
Subject: Re: [RFC PATCH 02/12] netfs: Add an iov_iter to the read subreq for the network fs/cache to use
From: David Howells <dhowells@xxxxxxxxxx>
Date: Wed, 21 Jul 2021 18:20:14 +0100
Cc: dhowells@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>, Dominique Martinet <asmadeus@xxxxxxxxxxxxx>, Mike Marshall <hubcap@xxxxxxxxxxxx>, David Wysochanski <dwysocha@xxxxxxxxxx>, Shyam Prasad N <nspmangalore@xxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, linux-cachefs@xxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, v9fs-developer@xxxxxxxxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <0555748529d483fb9b69eceb56bf9ebc1efceaf1.camel@redhat.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <0555748529d483fb9b69eceb56bf9ebc1efceaf1.camel@redhat.com> <162687506932.276387.14456718890524355509.stgit@warthog.procyon.org.uk> <162687509306.276387.7579641363406546284.stgit@warthog.procyon.org.uk>

Jeff Layton <jlayton@xxxxxxxxxx> wrote:

> > -	iov_iter_xarray(&iter, WRITE, &subreq->rreq->mapping->i_pages,
> > +	iov_iter_xarray(&iter, READ, &subreq->rreq->mapping->i_pages,
> 
> What's up with the WRITE -> READ change here? Was that a preexisting
> bug?

Actually, yes - I need to split that out and send it to Linus.

David

References:
- Re: [RFC PATCH 02/12] netfs: Add an iov_iter to the read subreq for the network fs/cache to use
  - From: Jeff Layton
- [no subject]
  - From: David Howells
- [RFC PATCH 02/12] netfs: Add an iov_iter to the read subreq for the network fs/cache to use
  - From: David Howells

Prev by Date: Re: [RFC PATCH 02/12] netfs: Add an iov_iter to the read subreq for the network fs/cache to use
Next by Date: Re: [RFC PATCH 03/12] netfs: Remove netfs_read_subrequest::transferred
Previous by thread: Re: [RFC PATCH 02/12] netfs: Add an iov_iter to the read subreq for the network fs/cache to use
Next by thread: [RFC PATCH 03/12] netfs: Remove netfs_read_subrequest::transferred
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]